test: fix flaky 'limit reset per Local storage' test#451
Open
antonisetkowicz wants to merge 1 commit into
Open
test: fix flaky 'limit reset per Local storage' test#451antonisetkowicz wants to merge 1 commit into
antonisetkowicz wants to merge 1 commit into
Conversation
Replace setTimeout-based timing with node:test mock.timers for deterministic behavior. The test was skipped since it relied on real-time delays which made it flaky in CI. Closes #698 (inline TODO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
limit reset per Local storagetest was marked asskip: truewith a TODO comment asking to rewrite it using fake timers instead ofsetTimeout.This PR:
setTimeout-based timing withnode:testbuilt-inmock.timers(already used by other tests in this file)await fastify.inject()+clock.tick()instead of parallel setTimeout callbacks{ skip: true }flag so the test runs in CI againBefore
setTimeoutdelaysAfter
Checklist
node --test test/route-rate-limit.test.js— 39 pass, 0 failnode --test test/*.test.js— 101 pass, 0 failnode:testmock timers)