fix: Async key provider and errors should be resolved internally -- dynamic JWTs in tests #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I've been very busy lately and I completely forgot about it. It looks good. Thank you. Just hold this pr instead of mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates JWTs dynamically in tests as requested by @mcollina on #335.
If there's a way to apply this change to the original PR, please point me toward it and I'll do it.
This PR includes the changes @NikitaFedorov1 made for PR 335. My understanding of his comment in 335 is that he does not intend to apply the test changes requested. I just changed a few lines in his tests (commit #5) so others can get the benefit of this fix.
I broke the tests several times before getting them right, so I know they can fail. 😄 Also confirmed response bodies/error details matched those from the hard coded tokens while working on the tests.
PR 335 description
False positive tests: test: Async key provider errors should be resolved internally
Fix & test fix: feat: Async key provider
Related issue: #334
Checklist
npm run testandnpm run benchmarkand the Code of conduct