Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add key option to sign and verify #314

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

KirillTregubov
Copy link
Contributor

@KirillTregubov KirillTregubov commented Nov 4, 2023

Closes #313

Checklist

@gurgunday
Copy link
Member

Can you add a test for the type?

@Eomm Eomm added the typescript TypeScript related label Nov 6, 2023
@KirillTregubov
Copy link
Contributor Author

I have added tests to the jwt.test-d.ts file.

Interestingly, while looking around in the codebase, I could not find a justification for the onlyCookie definition on the VerifyOptions type. It is not documented in the README, and onlyCookie does not seem to be used in the verify function inside jwt.js. Please let me know if this is safe to remove.

types/jwt.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit bd9f9bb into fastify:master Nov 11, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key option is not defined in the types
4 participants