Repository navigation
fix(compare): handle missing results directory - #497
Merged
Tony133 merged 1 commit intoNov 14, 2026
Merged
Conversation
ilteoood
approved these changes
Nov 3, 2026
|
Tested locally on Node 24 (Windows). Running Works identically when specifying |
Tony133
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark comparecrashes withENOENT: no such file or directory, scandir '<cwd>/results'when the results directory for the selected scenario does not exist. This happens on a fresh clone before any benchmark run, and with-s postafter running only the GET scenario. The command already has a friendly message for this case ("Benchmark to gather some results to compare."), butreaddirSyncthrows before the check runs.This change makes
getAvailableResults()return an empty list when the results directory is missing, so the existing message is shown and the command exits with code 0.Fixes #496
How to reproduce
After the change, both commands print
Benchmark to gather some results to compare.and exit 0. Comparing existing results is unchanged.Checklist
npm run test && npm run benchmark --if-presentnpm testrunsstandardonly. Verified manually with the commands above.)and the Code of conduct