Skip to content

Add a bash script to run some benchmarks on AWS#43

Merged
jaja360 merged 10 commits into
masterfrom
tests
Jun 26, 2025
Merged

Add a bash script to run some benchmarks on AWS#43
jaja360 merged 10 commits into
masterfrom
tests

Conversation

@jaja360
Copy link
Copy Markdown
Collaborator

@jaja360 jaja360 commented Jun 24, 2025

This PR:

  • Adds scripts/aws_tests.bash which launches multiple AWS instances, runs the existing generate_multiple_tables.py on each of them, and pull back the generated tables locally.
  • Fixes an issue with the uniform_all generator (now called logscall_all).

jaja360 added 5 commits June 23, 2025 18:01
- It always produced 'inf' because the range was greater than
  mt19937_64's limit
- It makes more sense to use a logscale to better cover the range of
  possible floating values: uniform_all -> logspace_all
@jaja360 jaja360 requested a review from lemire June 24, 2025 02:51
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash
Comment thread scripts/aws_tests.bash Outdated
Comment thread scripts/aws_tests.bash
Copy link
Copy Markdown
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

My comments are non-blocking, just superficial comments.

Principally, this PR:
  - makes security_group and ssh_key configurable via env variables
  - generates them automatically if unspecified
  - adds some checks and comments
  - adds x86 instances.
@jaja360 jaja360 merged commit 66a37ea into master Jun 26, 2025
8 checks passed
@jaja360 jaja360 deleted the tests branch June 26, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants