Better stats#42
Merged
Merged
Conversation
jaja360
reviewed
Jun 17, 2025
Collaborator
jaja360
left a comment
jaja360
left a comment
There was a problem hiding this comment.
The howmany_digits variable seems to never be incremented. I'll push a patch.
Collaborator
|
I realized by reading this PR that we don't need to set default values for boolean args with cxxopts. I uniformized the syntax for all such arguments, and fixed a small bug. I think we can now merge. |
Member
Author
|
@jaja360 If you are happy, let us merge!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, which approaches provide a shortest string? It turns out that, if my code is correct, none of them do!!!