Skip to content

comparison between our to_chars and dragonbox's to_chars #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaja360 merged 1 commit into from
May 10, 2025
Merged

comparison between our to_chars and dragonbox's to_chars #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions benchmarks/benchmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,37 @@ void process(const std::vector<TestCase<T>> &lines,
const std::array<BenchArgs<T>, Benchmarks::COUNT> &args,
const std::vector<std::string> &algo_filter) {
// We have a special algorithm for the string generation:
if (const std::string just_string = "just_string";
!algo_filtered_out(just_string, algo_filter)) {
if (!algo_filtered_out("just_string", algo_filter)) {
std::vector<diy_float_t> parsed;
for(const auto d : lines) {
const auto v = jkj::grisu_exact(d.value);
parsed.emplace_back(v.significand, v.exponent, v.is_negative);
}
pretty_print(parsed, just_string, [](const std::vector<diy_float_t>& parsed) -> int {
pretty_print(parsed, "just_string_ours", [](const std::vector<diy_float_t>& parsed) -> int {
int volume = 0;
char buf[100];
std::span<char> bufspan(buf, sizeof(buf));
for (const auto v : parsed)
volume += to_chars(v.significand, v.exponent, v.is_negative, bufspan.data());
return volume;
}, 100);
pretty_print(parsed, "just_string_dragonbox", [](const std::vector<diy_float_t>& parsed) -> int {
using traits = jkj::dragonbox::default_float_traits<T>;
using carrier_uint = typename traits::carrier_uint;
int volume = 0;
char buf[100];
std::span<char> bufspan(buf, sizeof(buf));
for (const auto v : parsed) {
char* ptr = bufspan.data();
if(v.is_negative) *ptr++ = '-';
const char* end = jkj::dragonbox::to_chars_detail::to_chars<T, traits>(
static_cast<carrier_uint>(v.significand), v.exponent, ptr);
volume += end - bufspan.data();
}
return volume;
}, 100);
} else {
fmt::println("# skipping {}", just_string);
fmt::println("# skipping just_string");
}

for (const auto &algo : args) {
Expand Down