script to generate LaTeX tables from our benchmark outputs#35
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a script to generate LaTeX tables from benchmark outputs and updates the README with instructions on its usage.
- Added a new Python script (latex_table.py) to parse benchmark outputs and format them as a LaTeX table.
- Updated the README with usage instructions for running the script.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/latex_table.py | Added a new script with functions for formatting numbers and parsing input data, but contains a typo in the main guard and debugging prints that should be removed. |
| scripts/README.md | Added a new README file with instructions to run the LaTeX table generator. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Python script that converts benchmark outputs into LaTeX tables and updates the README with instructions to run the script.
- Adds the script (latex_table.py) for parsing benchmark data and formatting it into a LaTeX table
- Updates the README with detailed usage instructions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/latex_table.py | New script to parse benchmark data, generate a LaTeX table, and output formatted results; includes several debugging print statements and specific numeric value handling |
| scripts/README.md | Added instructions on running benchmarks and generating LaTeX tables from the output |
Comments suppressed due to low confidence (1)
scripts/latex_table.py:9
- Consider formatting a value of 0 as a valid numeric output instead of returning 'N/A', unless this behavior is intentional.
if not isinstance(value, (int, float)) or value == 0:
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Python script for generating LaTeX tables from benchmark output data and updates the README with instructions to run the script.
- Added scripts/latex_table.py to parse benchmark output and format it into a LaTeX table
- Added scripts/README.md updates to guide users through generating tables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/latex_table.py | New script to convert benchmark outputs into a formatted table |
| scripts/README.md | Documentation update guiding usage of the new script |
Comments suppressed due to low confidence (1)
scripts/latex_table.py:30
- [nitpick] The variable name 'format' shadows the built-in function 'format'. Consider renaming it, for example to 'formatted_value'.
format = f"{'-' if is_negative else ''}{abs_value*10**exponent}"
jaja360
left a comment
There was a problem hiding this comment.
I looked at the code and tested it. Everything seems perfect !
|
I think we can merge this ? |
|
Let us do so !!! Now we have to print out the actual tables and do some work! :-) |
With this script, we can turn a benchmark run into a proper LaTeX table. Of course, it is possible to manually adjust the table afterward.
We could possibly use this script to generate a couple of table per platform (using our data files).
I am including instructions (see README.md file in the scripts directory).