Some tuning#33
Merged
Merged
Conversation
jaja360
approved these changes
Apr 19, 2025
Member
Author
|
@jaja360 Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (master):
This PR:
So slightly fewer instructions.
What my results seem to indicate is that we are heavily bounded on the string generation part. That is, printing out the characters is the slow part.
I think that teju_jagua fails exhaustivefloat32, but it did before too... so I do not think it is a new bug.
Interestingly, merely printing the characters from the mantissa can be slower than the whole dragonbox algorithm !!!