Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required python version from 3.7 to 3.8 #968

Closed

Conversation

zarch
Copy link

@zarch zarch commented Sep 2, 2024

mkdocs-material==9.5.33 depends on Python>=3.8 therefore we should:

  • upgrade the minimum python version of typer to a compatible version and therefore change pyproject.toml file or
  • downgrade mkdocs-material to a compatible version with python 3.7.

Considering that Python3.7 end of life was 2023-06-27, it seems reasonable to require as minimum version python3.8 (end of life due 2024-10).

See discussion

Copy link

github-actions bot commented Sep 2, 2024

📝 Docs preview for commit 5cb3b98 at: https://39a79517.typertiangolo.pages.dev

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Our build-docs workflow is run on a Python 3.11 instance, so I don't think there's an issue with the versioning of mkdocs-material. [Update: actually, let me look into this more.]

We will drop support for Python 3.7 at some point though. When we do, we'll need many more changes than just changing the project.toml. This work is already being prepared in PR #830. We can close this PR and continue in #830.

@svlandeg svlandeg self-assigned this Sep 3, 2024
@svlandeg
Copy link
Member

svlandeg commented Sep 3, 2024

According to the mkdocs-material release notes, Python 3.7 has already been dropped since their v9.3.0, back in September 2023. We've been testing Typer on the CI with Python 3.7 though, and this has never been an issue 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants