✅ Add needs_bash test fixture
#888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
changed the title
needs_bash instead of needs_linuxneeds_bash instead of needs_linux
svlandeg
added
bug
svlandeg
changed the title
needs_bash instead of needs_linuxneeds_bash test fixture
|
Great, thank you @svlandeg! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generalized the test suite to also run on Windows and Mac, we introduced a fixture
needs_linuxto only run two specific tests on Bash/Linux. However, these specific tests may fail on a Linux system with a different shell. So, this PR adds the fixture toneeds_bashas well. Only keepingneeds_bashis not sufficient as MacOS tests will fail on the CI.Thanks to @rokbot for pointing this out in #866.
In follow-up work, ideally we should extend these tests to make them more applicable across OS and shell versions, but I want to get this quick fix in first to avoid having the test suite fail on non-bash Linux systems.