-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix support for UnionType with Python 3.11 #676
Conversation
8b29313
to
a4fee7d
Compare
a4fee7d
to
3881eb1
Compare
This worked like a charm! Thank you! |
This is a very nice addition 👍 |
Hello everyone, |
Sorry, I cannot, I haven't write access to this repository. |
The PR seems wonderful, why hasn't it been added yet? |
|
also resolves #348 |
Are there any updates on this pull request. Would love to not need to use |
@disrupted is @tiangolo the only one that can merge? Seems a bit wasteful that this is sitting here with 2 approves and a passing CI just waiting. |
Looks like it. My review only has symbolic value as I am not a maintainer. |
Related PR: #548 |
Will this be merged anytime soon? @tiangolo This has become a sore point with Typer in our code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this behaviour works in 3.10 but broke in 3.11, and the unit test introduced in this PR captures the bug nicely.
The fix is very clean and minimal, using the variables from _typing
that were introduced precisely for this type of usage.
Thanks for the contribution @standag!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please merge.
Dear Sebastian @tiangolo , |
Resolves #533