Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use value.name as input value for enums #152

Closed
wants to merge 1 commit into from
Closed

use value.name as input value for enums #152

wants to merge 1 commit into from

Conversation

sapristi
Copy link

@sapristi sapristi commented Aug 7, 2020

This is a pull request related to #151

I did not change the value provided to the function (still an instance of the Enum class, not value.value as stated in the issue).
If you are ok with these changes I will try to update the documentation as well.

@sirex
Copy link

sirex commented Jan 21, 2021

I think, this can be closed, I have a working version with green tests: #224

@sapristi sapristi closed this Jan 22, 2021
@tiangolo
Copy link
Member

Thanks for the help here @sirex ! 👏 🙇

Thanks for reporting back and closing the issue @sapristi 👍

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants