Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wrapApiError to support non-Errors #138

Merged
merged 1 commit into from
May 9, 2023
Merged

Allow wrapApiError to support non-Errors #138

merged 1 commit into from
May 9, 2023

Conversation

ted-faros
Copy link
Contributor

Description

We encountered an situation where wrapApiError threw:

[ERR_ASSERTION]: err must be an Error at Function.VError.cause

This change handles that case by wrapping the non-Error.

Type of change

  • Bug fix
  • New feature
  • Breaking change

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ted-faros ted-faros merged commit eb7a734 into main May 9, 2023
@ted-faros ted-faros deleted the tt/wrap-error branch May 9, 2023 23:05
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants