Skip to content

Commit

Permalink
FAI-9501: Remove Clio visibility feature (#257)
Browse files Browse the repository at this point in the history
  • Loading branch information
ted-faros committed May 21, 2024
1 parent 9501897 commit be2a3bb
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
5 changes: 0 additions & 5 deletions src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export class FarosClient {
private readonly api: AxiosInstance;
readonly graphVersion: GraphVersion;
readonly phantoms: Phantom;
readonly visibility?: string;

constructor(
private readonly cfg: FarosClientConfig,
Expand Down Expand Up @@ -66,7 +65,6 @@ export class FarosClient {

this.graphVersion = useGraphQLV2 ? GraphVersion.V2 : GraphVersion.V1;
this.phantoms = cfg.phantoms || Phantom.IncludeNestedOnly;
this.visibility = cfg.visibility;
}

copy(
Expand Down Expand Up @@ -213,9 +211,6 @@ export class FarosClient {
const result: Dictionary<any> = {};
if (this.graphVersion === GraphVersion.V2) {
result.phantoms = this.phantoms;
if (this.visibility) {
result.visibility = this.visibility;
}
}
return result;
}
Expand Down
1 change: 0 additions & 1 deletion src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ export interface FarosClientConfig {
readonly apiKey: string;
readonly useGraphQLV2?: boolean;
readonly phantoms?: Phantom;
readonly visibility?: string;
}

export enum GraphVersion {
Expand Down
14 changes: 0 additions & 14 deletions test/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,20 +208,6 @@ describe('client', () => {
mock.done();
}

test('v2 query parameters - visibility', async () => {
const expected = new URLSearchParams({
phantoms: Phantom.IncludeNestedOnly,
visibility: 'foobar',
});
const clientConfig = {
url: apiUrl,
apiKey: 'test-key',
useGraphQLV2: true,
visibility: 'foobar',
};
await expectV2Request(clientConfig, expected);
});

test('v2 query parameters - default', async () => {
const expected = new URLSearchParams({
phantoms: Phantom.IncludeNestedOnly,
Expand Down

0 comments on commit be2a3bb

Please sign in to comment.