Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airbyte v40 #295

Merged
merged 22 commits into from
May 19, 2023
Merged

Airbyte v40 #295

merged 22 commits into from
May 19, 2023

Conversation

thomas-gerber
Copy link
Contributor

@thomas-gerber thomas-gerber commented May 16, 2023

Description

Moving to Airbyte 0.40.9
Also:
Fixes #197
Fixes #288

TODO:

  • Add the other sources besides the main 4
  • documentation links need to be changed as the IDs are not fixed anymore
  • migration strategy
  • docker extension upgrade (separate PR, once the new init is released

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Migration

A simple restart will upgrade users to 0.40.9. Note that those migrated users will remain on their existing sources and Faros destination versions (until we re-enable auto-update).
This was tested the following way:

  1. start an older version of CE (Airbyte v0.39.37-alpha)
  2. sync Jira and GitHub data through the CLI
  3. stop that older Faros, but do not delete the volumes
  4. start a newer version of CE (this branch, on Airbyte v0.40.9)
  5. do an incremental sync on those 2 sources

Ability to update source schema for canned sources

It will work if the starting version of CE is after this merge. Older users of Faros still have to recreate the sources and connections.
This was tested the following way:

  1. start a newer version of CE
  2. configure the GitHub source and sync it
  3. in the connection replication settings, refresh source schema
  4. one sees all the streams we haven't configured as new, and all existing streams as having been modified
  5. enable pull_request_stats and save
  6. sync again, and that new stream catches up

A note on sync mode

We either use Incremental with append_dedup if incremental is available source-side, full_refresh with overwrite otherwise. Note that we don't fully abide by the spec, as we do NOT delete the data for that stream in the overwrite mode. Unfortunately, there is no sync mode that describes that behavior ATM.

Note that all existing streams are marked as modified only because we didn't pass along the json schema during canned setup, which is now captured for the first time

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber thomas-gerber changed the title Cwu/v40 Airbyte v40 May 16, 2023
.env Outdated Show resolved Hide resolved
docker-extension/.env Outdated Show resolved Hide resolved
@ogusak
Copy link
Contributor

ogusak commented May 16, 2023

If we plan on upgrading k8s deploy - this needs to be changed as well

@thomas-gerber
Copy link
Contributor Author

If we plan on upgrading k8s deploy - this needs to be changed as well

Fixed

init/package.json Outdated Show resolved Hide resolved
init/src/airbyte/initv40.ts Outdated Show resolved Hide resolved
@thomas-gerber thomas-gerber merged commit 80c0b69 into main May 19, 2023
@thomas-gerber thomas-gerber deleted the cwu/v40 branch May 19, 2023 20:06
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants