-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airbyte v40 #295
Merged
Merged
Airbyte v40 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusing old config files
Currently disabled: force re-setup, connector auto-upgrade
Instead, we set it to {}
also synced with the kube .env
additional cleanup
thomas-gerber
requested review from
cjwooo,
tovbinm,
ypc-faros and
ogusak
as code owners
May 16, 2023 21:52
ogusak
reviewed
May 16, 2023
If we plan on upgrading k8s deploy - this needs to be changed as well |
Fixed |
ogusak
approved these changes
May 16, 2023
cjwooo
reviewed
May 17, 2023
ypc-faros
reviewed
May 17, 2023
cjwooo
reviewed
May 18, 2023
cjwooo
approved these changes
May 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving to Airbyte 0.40.9
Also:
Fixes #197
Fixes #288
TODO:
Type of change
Migration
A simple restart will upgrade users to 0.40.9. Note that those migrated users will remain on their existing sources and Faros destination versions (until we re-enable auto-update).
This was tested the following way:
Ability to update source schema for canned sources
It will work if the starting version of CE is after this merge. Older users of Faros still have to recreate the sources and connections.
This was tested the following way:
A note on sync mode
We either use Incremental with append_dedup if incremental is available source-side, full_refresh with overwrite otherwise. Note that we don't fully abide by the spec, as we do NOT delete the data for that stream in the overwrite mode. Unfortunately, there is no sync mode that describes that behavior ATM.
Note that all existing streams are marked as modified only because we didn't pass along the json schema during canned setup, which is now captured for the first time
Checklist