Skip to content

fix: align markdown metadata base URLs#224

Closed
Kinfe123 wants to merge 1 commit into
mainfrom
codex/fix-markdown-frontmatter-review
Closed

fix: align markdown metadata base URLs#224
Kinfe123 wants to merge 1 commit into
mainfrom
codex/fix-markdown-frontmatter-review

Conversation

@Kinfe123
Copy link
Copy Markdown
Member

@Kinfe123 Kinfe123 commented May 27, 2026

Summary

  • reuse the existing YAML string serializer for markdown frontmatter
  • derive markdown frontmatter and canonical Link header origins from the shared docs metadata base-url resolver
  • cover sitemap.baseUrl-driven markdown metadata in the Fumadocs API test

Verification

  • pnpm exec oxfmt --ignore-path .oxfmtignore packages/docs/src/agent.ts packages/fumadocs/src/docs-api.ts packages/fumadocs/src/docs-api.test.ts packages/tanstack-start/src/server.ts packages/astro/src/server.ts packages/svelte/src/server.ts packages/nuxt/src/server.ts
  • pnpm --filter @farming-labs/docs exec vitest run src/agent.test.ts
  • pnpm --filter @farming-labs/docs run build
  • pnpm --filter @farming-labs/theme exec vitest run src/docs-api.test.ts
  • pnpm --filter @farming-labs/docs run typecheck
  • pnpm --filter @farming-labs/theme run typecheck
  • pnpm --filter @farming-labs/tanstack-start run typecheck
  • pnpm --filter @farming-labs/astro run typecheck
  • pnpm --filter @farming-labs/svelte run typecheck
  • pnpm --filter @farming-labs/nuxt run typecheck

Summary by cubic

Aligns markdown metadata base URLs across all adapters and the Docs API so canonical and markdown URLs use the shared docs metadata base URL. Fixes mismatched origins when sitemap.baseUrl or LLM settings are set.

  • Bug Fixes
    • Use the shared base-url resolver for frontmatter and Link headers in packages/astro, packages/nuxt, packages/svelte, packages/tanstack-start, and the fumadocs API.
    • Replace the custom YAML stringifier with the shared serializer for markdown frontmatter.
    • Add a test asserting sitemap.baseUrl drives canonical and .md URLs.

Written for commit 599cbc6. Summary will update on new commits. Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-website Building Building Preview, Comment May 27, 2026 12:38pm

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

Open in StackBlitz

@farming-labs/astro

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro@224

@farming-labs/astro-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro-theme@224

@farming-labs/docs

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/docs@224

@farming-labs/theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/theme@224

@farming-labs/next

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/next@224

@farming-labs/nuxt

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt@224

@farming-labs/nuxt-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt-theme@224

@farming-labs/svelte

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte@224

@farming-labs/svelte-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte-theme@224

@farming-labs/tanstack-start

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/tanstack-start@224

commit: 599cbc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant