support fname signature verifications #173
Conversation
CassOnMars
force-pushed
the
fname-verification
branch
from
8eb258f to
6579151
Compare
src/storage/store/engine.rs
Outdated
| let proof = fname_transfer.proof.as_ref().unwrap(); | ||
| // TODO: Verify the EIP-712 server signature | ||
|
|
||
| match fname_transfer.verify_signature() { |
There was a problem hiding this comment.
We should also do the same thing here https://github.com/farcasterxyz/snapchain-v0/blob/f5f1aff56fc11f9fb8421e6eeab9277628e35998/src/storage/store/engine.rs#L853-L855 for username proof claim signatures (I just looked and looks like we never call verifyUserNameProofClaim in hubs, this might be a bug?) and the eth verified addresses.
Could you also implement sol verified addresses (maybe in a separate PR? upto you) before moving on to the other validations?
src/core/message.rs
Outdated
| )); | ||
| } | ||
|
|
||
| let json = json!({ |
There was a problem hiding this comment.
We should make this a const inside validations.ts
CassOnMars
force-pushed
the
fname-verification
branch
from
b8febe6 to
a6f8802
Compare
|
The existing test failing is correct for failing, this test has invalid parameters, but we should add helpers to streamline generating valid signed payloads for tests instead. |
No description provided.