Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.ts) - error handling #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cryptoryda
Copy link

@cryptoryda cryptoryda commented Dec 29, 2024

REASON:

  • Using optional chaining ensures that if response.error is undefined or null, the code won't throw a runtime error. Instead, it gracefully checks whether error exists before attempting to access its type property.

ACTUAL CHANGE MADE:

  • fix from
if (response.error.type === 'rejected_by_user') {
        throw new SignIn.RejectedByUser()
      }

to

  if (response.error?.type === "rejected_by_user") {
        throw new SignIn.RejectedByUser();
      }
  • other same fixes in file sdk.ts to handle type of error.

Copy link

changeset-bot bot commented Dec 29, 2024

⚠️ No Changeset found

Latest commit: 43561ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cryptoryda
Copy link
Author

Hi @deodad
Feel free to let me know if you have any questions regarding this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant