Skip to content
This repository has been archived by the owner on Jul 25, 2018. It is now read-only.

Compliance to latest spec (Issue #2) #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compliance to latest spec (Issue #2) #3

wants to merge 1 commit into from

Conversation

nadameu
Copy link

@nadameu nadameu commented Aug 17, 2017

No description provided.

@davidchambers
Copy link
Member

I think we should also set the fantasy-land dependency to "3.3.x" or "3.x.x".

@safareli
Copy link
Member

and add fantasy-land/ prefixes

@davidchambers
Copy link
Member

and add fantasy-land/ prefixes

I believe we're doing this already by using [ap] rather than .ap.

@nadameu nadameu mentioned this pull request Aug 18, 2017
Open
@safareli
Copy link
Member

@davidchambers oh yes, didn't noticed.

@wojpawlik
Copy link

wojpawlik commented Apr 26, 2018 •
edited
Loading

This PR breaks tests for applicative interface:

io.js
✖ io - All (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:77:33
    at rec (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:34:38)
    at Ctor.Cons (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:39:20)
    at Ctor.cata (D:\Wojciech\JS\fantasy-io\node_modules\daggy\daggy.js:134:40)
    at Ctor.Seq.fold (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:37:17)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:76:41)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16

✖ io - Identity (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Composition (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:24:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Homomorphism (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:32:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Interchange (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:40:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadameu @davidchambers @safareli @wojpawlik