Add Backdrop Style Option #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuller18
added a commit
to lmuller18/avataaars-generator
that referenced
this pull request
Oct 3, 2019
This will longer needed if fangpenlin/avataaars#25 gets merged
|
Update to Avataaars Generator is handled in fangpenlin/avataaars-generator#40. |
|
Please merge this! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reasoning
I wanted the ability to change the color of my avataaars' backdrops. Rather than changing the png or svg manually I wanted to do it right and implement the backdrop as an option in the generator. With this setup, other shapes and masks could be added to new Backdrop Options and pull from the same Selector like clothes, face, and top do.
Fixes #12