This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Misspelled word in javascript comment line #2642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- package.json main file points to uncompressed version; - new "onFullscreenChange" event; - it is now possible to make elements clickable by setting `data-selectable="true"`; - fixed issue when ajax response contains additional elements; - improved "hash" module;
- Focus method now looks for first input with `autofocus` attribute
- It is now possible to set only one dimension (width or height) for iframes (example: `iframe : { css : { width : '100%' }}`)
- Removed `unbind` method for jQuery v3 compatibility
- New options:
`defaultType : 'image' ` - Default content type if cannot be detected automatically
`thumbs.parentEl : '.fancybox-container'` - Selector for element where thumbnails grid will be injected
- Option `margin` now has default value 0 for mobile devices
- Container is now placed at the bottom of the <body>
- Thumbnail list should now scroll properly when `autoStart` is enabled
- Share module uses current page link if hash module is not disabled
- Bugfixes
Automatically play first video/audio media element on opening and pause all on closing.
- redesigned share module; - switched mouse wheel direction (down/right=next); - improved touch handling (it is now possible to swipe inline content that is larger than container); - inline content is now preloaded (e.g., next/previous `image`/`inline` gallery items are now loaded on start) - Options width/height now can be used to set image max dimensions; this is also useful for setting dimensions for SVG images.
New option "share{ url: function(){} }" to customize URL for share modal. Demo - https://codepen.io/fancyapps/pen/BrOqmQ?editors=1010
+ fixed typo from the previous commit
This is to make it much easier to load the CSS when using a import tool like postcss-import, etc.
Multiple bug fixes and improvements
updated license URL for fancybox 3
Added style line to package.json, accepts @import
* Revised focus trapping; * Navigation arrows are now buttons; * Slideshow now waits for html5 video to end; * Changed window.jQuery to global value; * Fixed issue with 2inline items in looping group * Fixed issue with custom full-screen button
- Updated slideshow
1) now waits for yt, vimeo video to end
2) added progressbar
- Revised transitions
- Slightly updated visuals
- Fixed IE11 issues
- New option `preventCaptionOverlap` enabled by default for desktop only; - HTML5 video now uses thumbnail image as poster; - Caption is now centered and without top border; caption does not hide when idling and `preventCaptionOverlap` is enabled; - It is now easier to set content height in % (especially for iframes), there is not need to adjust bottom margin and max-height as it is done automatically using JS - Fixed thumnbail visisbility detection (now works better with sliders); - Fixed share modal not closing on clicking outside content area; - Fixed iframe support for iOS
- Fix HTML5 video posters
Fixed #2090 - Html5 video in looping gallery; Fixed issue with long pdf files (by disabling iframe preloading)
URL without protocol does not work when using Fancybox locally without server.
URL without protocol does not work when using Fancybox locally without server.
- Fixed #2122 - Focusable HTML5 video - Fixed #2128 - Missing smallBtn on mobile - Fixed #2096 - autoStart fullscreen AND slideshow - Fixed #2097 - German translation - Fixed #2132 - Youtube fullscreen - Captions now have linear-gradient background (instead of background image for pseudo element) and can have max-height and vertical scrollbar - Improved design for phones having the notch (https://webkit.org/blog/7929/designing-websites-for-iphone-x/)
- Fixed #2147 - Caption overlaps bottom video-controls
- Fixed #2150 - Caption is not cleared
- Fixed #2151 - Swipes over the caption
Add protocol to jQuery URL
Fix documentation for base tpl
Update the version of jQuery to latest version
Remove a wrong semicolon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File : src/js/wheel.js
// ==========================================================================
//
// Wheel
// Basic mouse weheel support for gallery navigation
//
// ==========================================================================
must be
// ==========================================================================
//
// Wheel
// Basic mouse wheel support for gallery navigation
//
// ==========================================================================