Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default for enforceSupportedChains #390

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lochie
Copy link
Member

@lochie lochie commented Jun 3, 2024

No description provided.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-cra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:51am
connectkit-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:51am
connectkit-testbench ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:51am
connectkit-vite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:51am

@22Xy
Copy link

22Xy commented Aug 6, 2024

hi, i think it might be helpful if we mention enforceSupportedChains option in Getting Started docs. as someone coming along from v1.7.x, i expected the switch network modal pops up if the chain is not supported. thanks!

@lochie
Copy link
Member Author

lochie commented Aug 7, 2024

hi, i think it might be helpful if we mention enforceSupportedChains option in Getting Started docs. as someone coming along from v1.7.x, i expected the switch network modal pops up if the chain is not supported. thanks!

good suggestion @22Xy. i will be looking at updating the docs in the coming weeks, will be sure to include something about this too :)

@22Xy
Copy link

22Xy commented Aug 7, 2024

hi, i think it might be helpful if we mention enforceSupportedChains option in Getting Started docs. as someone coming along from v1.7.x, i expected the switch network modal pops up if the chain is not supported. thanks!

good suggestion @22Xy. i will be looking at updating the docs in the coming weeks, will be sure to include something about this too :)

sounds great. let me know if there is anything i can help! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants