Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENS resolution if mainnet not supported #351

Merged

Conversation

philogicae
Copy link
Contributor

Found issue:

Proposed solution:

  • Add useEnsFallbackConfig hook to easily guarantee mainnet access to all ENS-related hooks, regardless of the chains supported by the dapp.

Copy link

vercel bot commented Feb 15, 2024

@philogicae is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@philogicae
Copy link
Contributor Author

@lochie 👀

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-cra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 3:15am
connectkit-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 3:15am
connectkit-testbench ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 3:15am
connectkit-vite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 3:15am

Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution @philogicae! Sorry for the delay in reviewing this, and many thanks for taking the time to put this together 🙏

@philogicae
Copy link
Contributor Author

Btw @lochie, if you need some help from external reviewers, don't hesitate to reach me. Always happy to contribute to quality open source projects when I have time ✌️

@lochie lochie merged commit e16376a into family:main Mar 26, 2024
6 checks passed
@lochie
Copy link
Member

lochie commented Mar 26, 2024

Btw @lochie, if you need some help from external reviewers, don't hesitate to reach me. Always happy to contribute to quality open source projects when I have time ✌️

Thanks @philogicae, I really appreciate that! Will tag you if anything comes up 😊

@lochie
Copy link
Member

lochie commented Mar 28, 2024

This feature is now available in ConnectKit 1.7.3 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants