-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove initialData in nonce and session #349
Remove initialData in nonce and session #349
Conversation
It appears that in @tanstack/react-query v5 and up the query will not be fetched on mount if `initialData` is set. This means that the `ckSiweNonce` and `ckSiweSession` queries don't fire until their respective intervals have elapsed. This commit removes the `initialData` for both of these queries in order to restore previous functionality.
@JamieLottering is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
Hi team, I appreciate you are very busy but I am respectfully asking for some eyes on this. Currently in the process of migrating to viem 2.0 (which requires us to update wagmi to 2.0, react-query to v5, and connectkit to 1.7) and this is the last issue keeping us from wrapping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @JamieLottering! Was on my list to debug why SIWE had an issue when first trying to connect and this seems to resolve those problems 🙌
Awesome, thank you for merging!! |
This update is now in ConnectKit |
It appears that in @tanstack/react-query v5 and up the query will not be fetched on mount if
initialData
is anything other thanundefined
. This means that theckSiweNonce
andckSiweSession
queries don't fire for the first time until their respective intervals have elapsed.This commit removes the
initialData
for both of these queries in order to restore previous functionality.Versions used to reproduce issue:
"@tanstack/react-query": "5.18.1"
&"connectkit": "1.7.1"