Provide exports.types in package.json
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-grover is attempting to deploy a commit to the LFE Team on Vercel. A member of the Team first needs to authorize it. |
|
Interesting, I really appreciate the PR! I'm going to look into this a bit more to make sure this config is correct before merging. Thanks 🙏 |
|
of course, let me know if I can help! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Seeing |
lochie
approved these changes
Sep 7, 2023
|
This PR is now available in ConnectKit Thanks @alex-grover 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #229, the
package.jsonis not configured correctly. You can see the warning at https://publint.dev/[email protected] - whenexportsis specified, the top leveltypesis ignored.The workaround in that issue does work, but ConnectKit + TypeScript is broken with the default
create-next-apptemplate, so I think it's worth fixing.By my understanding, there are a couple possible resolutions here:
exportsfield in the package.json to identify both the js and types file (the approach in this PR).d.tsfile matches the name of the js file (i.e.index.es.d.ts)I'm not an expert in getting this stuff set up, but I did test by building locally and linking into an existing project. I believe this issue also exists in
connectkit-next-siwe, and I'm happy to make the same fix there if desired!