Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TokenPocket Wallet support #259

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat: Add TokenPocket Wallet support #259

merged 1 commit into from
Jul 17, 2023

Conversation

chendatony31
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 5, 2023

@chendatony31 is attempting to deploy a commit to the LFE Team on Vercel.

A member of the Team first needs to authorize it.

@chendatony31
Copy link
Contributor Author

Hi @lochie, I've checked the PR list, seems lots of injected wallets have the same problems. Maybe you can have some common changes about the issue? As lots of wallets have submitted info in wagmi repo here: https://github.com/wagmi-dev/references/blob/main/packages/connectors/src/utils/getInjectedName.ts#L6, i think you can using it.

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-cra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 7:31am
connectkit-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 7:31am
connectkit-testbench ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 7:31am
connectkit-vite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 7:31am

@lochie
Copy link
Member

lochie commented Jul 17, 2023

Hey @chendatony31, thanks for the PR!
re: injected wallets, we're currently optimising that setup, hopefully this will be in the next release to fix some of these issues and will display the wallet name instead of just "Browser Wallet"

Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the svg needs to be converted to jsx, and xmlns:xlink="http://www.w3.org/1999/xlink" needs to be removed from the svg tag or the build fails

@chendatony31
Copy link
Contributor Author

Ok, let me see.

@chendatony31
Copy link
Contributor Author

Done @lochie

Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lochie
Copy link
Member

lochie commented Jul 17, 2023

@chendatony31 could you pull the latest from the base branch so I can merge?

@chendatony31
Copy link
Contributor Author

Rebased @lochie

@lochie
Copy link
Member

lochie commented Jul 17, 2023

will be available in the next release. thanks @chendatony31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants