-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Trust Wallet connector option #242
Conversation
@Halibao-Lala is attempting to deploy a commit to the LFE Team on Vercel. A member of the Team first needs to authorize it. |
This update shows Trust Wallet option on wallet selection list. It also ensures Trust Wallet doesn't disappear when MetaMask and Coinbase Wallet are enabled. |
@lochie Hi mate, could you please review the code when you get time. Thanks |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chrisll-nodereal, I've made a few adjustments and tested on both Trust iOS and the Chrome extension. Seems to work nicely now.
Happy to merge, but I'm not sure why the additional check is necessary, does Trust do something different if MetaMask and Coinbase Wallet are present? 🤔
Hi @lochie, thanks for the review. It seems Injected wallet option doesn't show when Metamask is connected. The additional checking is to make sure that Trust Wallet option presents when Metamask or Coinbase Wallet is enabled. |
Enable Trust Wallet icon and text as an injected connector