Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Trust Wallet connector option #242

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

chrisll-nodereal
Copy link
Contributor

Enable Trust Wallet icon and text as an injected connector

@vercel
Copy link

vercel bot commented Jun 16, 2023

@Halibao-Lala is attempting to deploy a commit to the LFE Team on Vercel.

A member of the Team first needs to authorize it.

@chrisll-nodereal
Copy link
Contributor Author

This update shows Trust Wallet option on wallet selection list. It also ensures Trust Wallet doesn't disappear when MetaMask and Coinbase Wallet are enabled.

@chrisll-nodereal
Copy link
Contributor Author

chrisll-nodereal commented Jun 26, 2023

@lochie Hi mate, could you please review the code when you get time. Thanks

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-cra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 1:59pm
connectkit-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 1:59pm
connectkit-testbench ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 1:59pm
connectkit-vite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 1:59pm

Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisll-nodereal, I've made a few adjustments and tested on both Trust iOS and the Chrome extension. Seems to work nicely now.

Happy to merge, but I'm not sure why the additional check is necessary, does Trust do something different if MetaMask and Coinbase Wallet are present? 🤔

@lochie lochie merged commit 24ed760 into family:main Jul 17, 2023
2 checks passed
@Halibao-Lala
Copy link
Contributor

Hi @lochie, thanks for the review. It seems Injected wallet option doesn't show when Metamask is connected. The additional checking is to make sure that Trust Wallet option presents when Metamask or Coinbase Wallet is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants