refactor: Handling soft logout via a timer #2112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/set-timer-for-soft-logout
branch
from
0fcb866 to
24be928
Compare
krille-chan
force-pushed
the
krille/set-timer-for-soft-logout
branch
from
24be928 to
9b7e5c1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
- Coverage 55.67% 55.63% -0.05%
==========================================
Files 146 146
Lines 18337 18353 +16
==========================================
Hits 10210 10210
- Misses 8127 8143 +16
Continue to review full report in Codecov by Sentry.
|
td-famedly
reviewed
Jun 24, 2025
|
|
||
| async.Result? softLogoutResult; | ||
|
|
||
| while (softLogoutResult?.isValue != true) { |
There was a problem hiding this comment.
wouldn't #2033 with a debounce be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.