Handle call errors #2011
Handle call errors #2011
Conversation
coder-with-a-bushido
temporarily deployed
to
review
GitHub Actions
Inactive
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
8ccf963 to
ea71067
Compare
coder-with-a-bushido
temporarily deployed
to
review
GitHub Actions
Inactive
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
ea71067 to
3ca8e8b
Compare
coder-with-a-bushido
temporarily deployed
to
review
GitHub Actions
Inactive
There was a problem hiding this comment.
lg, do you maybe want to add a test for it? I think we could add a flag to MockWebRTCDelegate which tells it to throw an error on createPeerConnection and then we can confirm if the call is terminated as expected.
(feel free to modify the suggestion if you have better ideas!)
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
3ca8e8b to
f838d8e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
+ Coverage 55.89% 55.96% +0.07%
==========================================
Files 146 146
Lines 18926 18937 +11
==========================================
+ Hits 10579 10599 +20
+ Misses 8347 8338 -9
Continue to review full report in Codecov by Sentry.
|
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
f838d8e to
ce0712e
Compare
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
ce0712e to
2095a4f
Compare
coder-with-a-bushido
changed the title
| Logs().v('[VOIP] prepareMediaStream error => ${e.toString()}'); | ||
| Logs().v('[VOIP] preparePeerConnection error => ${e.toString()}'); | ||
| await _createPeerConnectionFailed(e); | ||
| rethrow; |
There was a problem hiding this comment.
sorry, forgot to remove it
| .getDisplayMedia(UserMediaConstraints.screenMediaConstraints); | ||
| } catch (e) { | ||
| await _getUserMediaFailed(e); | ||
| await _getDisplayMediaFailed(e); |
There was a problem hiding this comment.
hm this is a bit difficult to read, I don't think _getDisplayMediaFailed is reused, can we maybe remove the *failed methods and move the implementations in this block? it saves us the code jumping + might also remove the return null
Fixes https://famedly-ip.sentry.io/issues/6207590176/?project=1448986&query=is%3Aunresolved%20null%20check%20operator&referrer=issue-stream&statsPeriod=7d&stream_index=3