refactor: Make direct chat getter type safe #2005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/direct-chat-type-safe
branch
from
0d48ca9 to
c0a1002
Compare
| client.userID!, | ||
| 'm.direct', | ||
| directChats, | ||
| { |
There was a problem hiding this comment.
I think the 'markasdm' in commands_test.dart needs to be changed to account for this
This also makes sure that we do not accidentally change it in RAM before the change comes from the server when calling addToDirectChat()
krille-chan
force-pushed
the
krille/direct-chat-type-safe
branch
from
c0a1002 to
48c7448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes sure that we
do not accidentally change
it in RAM before the
change comes from the server
when calling
addToDirectChat()