Skip to content

chore: move modules to dedicated files - #3890

Merged
Shinigami92 merged 1 commit into
nextfrom
refactor-extract-module-class-files
Jun 25, 2026
Merged

chore: move modules to dedicated files#3890
Shinigami92 merged 1 commit into
nextfrom
refactor-extract-module-class-files

Conversation

@Shinigami92

@Shinigami92 Shinigami92 commented Jun 13, 2026

Copy link
Copy Markdown
Member

@Shinigami92 Shinigami92 self-assigned this Jun 13, 2026
@Shinigami92
Shinigami92 requested a review from a team as a code owner June 13, 2026 11:09
@netlify

netlify Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit fb6e939
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a3d6592dcaaca000814a0d6
😎 Deploy Preview https://deploy-preview-3890.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jun 13, 2026
@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.54246% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.85%. Comparing base (b504544) to head (fb6e939).

Files with missing lines Patch % Lines
src/modules/helpers/module.ts 94.84% 15 Missing and 2 partials ⚠️
src/modules/person/module.ts 94.02% 2 Missing and 2 partials ⚠️
src/modules/commerce/module.ts 98.59% 1 Missing ⚠️
src/modules/phone/module.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3890   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         923      923           
  Lines        3224     3224           
  Branches      591      591           
=======================================
  Hits         3187     3187           
  Misses         33       33           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/airline/module.ts 100.00% <100.00%> (ø)
src/modules/animal/module.ts 100.00% <100.00%> (ø)
src/modules/book/module.ts 100.00% <100.00%> (ø)
src/modules/color/module.ts 100.00% <100.00%> (ø)
src/modules/company/module.ts 100.00% <100.00%> (ø)
src/modules/database/module.ts 100.00% <100.00%> (ø)
src/modules/datatype/module.ts 100.00% <100.00%> (ø)
src/modules/date/module.ts 100.00% <100.00%> (ø)
src/modules/finance/module.ts 100.00% <100.00%> (ø)
src/modules/food/module.ts 100.00% <100.00%> (ø)
... and 17 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92

Copy link
Copy Markdown
Member Author

This PR is very easy to review, because the files were just renamed and index reexports it

you can compare line changes:

@ST-DDT ST-DDT added this to the v10.x milestone Jun 13, 2026
ST-DDT
ST-DDT previously approved these changes Jun 13, 2026

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is very easy to review, because the files were just renamed and index reexports it.

While this is true, it does cause a lot of more work for the SMF PRs than just doing it as part of the SMF PRs.

I'll find a way to automate the SMF refactoring again and then just rebase my SMF PRs, so I don't loose all my work/don't have to reject this.

@ST-DDT ST-DDT added needs rebase There is a merge conflict p: 1-normal Nothing urgent labels Jun 18, 2026
@ST-DDT

ST-DDT commented Jun 18, 2026

Copy link
Copy Markdown
Member

Looks like this needs a rebase.

@Shinigami92
Shinigami92 marked this pull request as draft June 18, 2026 11:12
@Shinigami92

Copy link
Copy Markdown
Member Author

converted to draft, I wont have time before next monday

@Shinigami92
Shinigami92 force-pushed the refactor-extract-module-class-files branch from 8718bdf to e8a45ed Compare June 22, 2026 17:28
@Shinigami92
Shinigami92 marked this pull request as ready for review June 22, 2026 17:29
@Shinigami92
Shinigami92 requested a review from ST-DDT June 22, 2026 17:32
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jun 22, 2026
ST-DDT
ST-DDT previously approved these changes Jun 22, 2026
@ST-DDT

ST-DDT commented Jun 25, 2026

Copy link
Copy Markdown
Member

This needs to be updated after that PR is merged:

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jun 25, 2026
@ST-DDT
ST-DDT marked this pull request as draft June 25, 2026 14:58
@Shinigami92
Shinigami92 force-pushed the refactor-extract-module-class-files branch from e8a45ed to fb6e939 Compare June 25, 2026 17:29
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jun 25, 2026
@Shinigami92
Shinigami92 requested a review from ST-DDT June 25, 2026 17:30
@Shinigami92
Shinigami92 marked this pull request as ready for review June 25, 2026 17:31

@xDivisionByZerox xDivisionByZerox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the implementation that was previously in **/index.ts now lives inside **/module.ts.

@Shinigami92
Shinigami92 added this pull request to the merge queue Jun 25, 2026
Merged via the queue into next with commit b517ae9 Jun 25, 2026
24 checks passed
@Shinigami92
Shinigami92 deleted the refactor-extract-module-class-files branch June 25, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants