feat(helpers): resolve primitive fake property chains - #3882
feat(helpers): resolve primitive fake property chains#3882puneetdixit200 wants to merge 1 commit into
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3882 +/- ##
==========================================
- Coverage 98.92% 98.89% -0.03%
==========================================
Files 908 908
Lines 3159 3165 +6
Branches 581 566 -15
==========================================
+ Hits 3125 3130 +5
- Misses 30 31 +1
Partials 4 4
🚀 New features to boost your workflow:
|
|
Thanks for contributing to faker. ❤️ Please note: This may cause a merge conflict with #3857 So this may take far longer than usual to merge. |
|
Please update the relevant jsdoc as well e.g. faker/src/modules/helpers/index.ts Line 1249 in 70994db |
|
There seems to be a merge conflict. Please resolve it and the prior comment, then mark the PR as ready for review again. |
|
Closing PR as abandonned. Feel free to ping, if you wish to update. |
Summary
Closes #3465
Verification
corepack pnpm exec vitest run test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tscorepack pnpm exec prettier --check src/modules/helpers/eval.ts test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tscorepack pnpm exec eslint src/modules/helpers/eval.ts test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tsgit diff --checkcorepack pnpm exec vitest run test/scripts/shared/markdown.spec.tscorepack pnpm run ts-checkcorepack pnpm run test