Skip to content

chore: consistent import paths in tests - #3858

Merged
ST-DDT merged 2 commits into
nextfrom
chore/test/consistent-imports
Jun 10, 2026
Merged

chore: consistent import paths in tests#3858
ST-DDT merged 2 commits into
nextfrom
chore/test/consistent-imports

Conversation

@ST-DDT

@ST-DDT ST-DDT commented May 23, 2026

Copy link
Copy Markdown
Member

During the review of #3857 I noticed that some imports in the test contain redundant parts.

This PR removes them for consistency with the other imports.

@ST-DDT ST-DDT self-assigned this May 23, 2026
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels May 23, 2026
@ST-DDT

ST-DDT commented May 23, 2026

Copy link
Copy Markdown
Member Author

Blocked by #3857 / SMF-PRs

@netlify

netlify Bot commented May 23, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit d411f47
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a27528a4255df000880468b
😎 Deploy Preview https://deploy-preview-3858.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label May 23, 2026
@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.92%. Comparing base (d11b5d3) to head (d411f47).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3858   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         910      910           
  Lines        3164     3164           
  Branches      582      582           
=======================================
  Hits         3130     3130           
  Misses         30       30           
  Partials        4        4           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT
ST-DDT marked this pull request as ready for review June 8, 2026 23:39
@ST-DDT
ST-DDT requested a review from a team as a code owner June 8, 2026 23:39
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Jun 8, 2026
@ST-DDT

ST-DDT commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

#3857 might take a while to get merged, so we might as well merge this one first.

@ST-DDT ST-DDT added this to the v10.x milestone Jun 10, 2026
@ST-DDT
ST-DDT added this pull request to the merge queue Jun 10, 2026
Merged via the queue into next with commit ec03e08 Jun 10, 2026
23 of 24 checks passed
@ST-DDT
ST-DDT deleted the chore/test/consistent-imports branch June 10, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants