Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disruptor: Correctly rethrow exception #354

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Disruptor: Correctly rethrow exception #354

merged 1 commit into from
Oct 18, 2024

Conversation

frankosterfeld
Copy link
Contributor

Don't rethrow the exception_ptr, but the contained exception.

@frankosterfeld
Disruptor: Correctly rethrow exception
46d4400 
Don't rethrow the exception_ptr, but the contained exception.

Signed-off-by: Frank Osterfeld <[email protected]>
wirew0rm
wirew0rm approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can be merged once CI passes.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wirew0rm wirew0rm merged commit bb8996b into main Oct 18, 2024
9 of 10 checks passed
@wirew0rm wirew0rm deleted the frank/fix-rethrow branch October 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirew0rm wirew0rm wirew0rm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankosterfeld @wirew0rm