Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable C++23, fix gcc-14 and clang-18 builds #347

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Enable C++23, fix gcc-14 and clang-18 builds #347

merged 4 commits into from
Apr 26, 2024

Conversation

frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Apr 25, 2024 •
edited
Loading

This should now also work when used from opendigitizer.

@frankosterfeld frankosterfeld marked this pull request as draft April 26, 2024 07:31
@frankosterfeld
Remove formatter for std::optional
43058c4 
fmt now ships its own.
@frankosterfeld
Fix experimental::source_location handling
283a2c8 
clang 18 moved it out of experimental.
@frankosterfeld
Enable C++23
37e6fb4 
Remove unmove, which doesn't compile with C++23 and was only used for
convenience in a test.
@frankosterfeld frankosterfeld changed the title Remove formatter for std::optional Enable C++23, fix gcc-14 and clang-18 builds Apr 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@frankosterfeld frankosterfeld marked this pull request as ready for review April 26, 2024 12:19
@wirew0rm wirew0rm merged commit 0fb3758 into main Apr 26, 2024
9 checks passed
@wirew0rm wirew0rm deleted the frank/fix-od branch April 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirew0rm wirew0rm wirew0rm approved these changes

@RalphSteinhagen RalphSteinhagen Awaiting requested review from RalphSteinhagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frankosterfeld @wirew0rm @RalphSteinhagen @restyled-commits