Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add sonarcube scanner and remove clang16/gcc12 #320

Merged
merged 2 commits into from
Oct 9, 2023
Merged

CI: add sonarcube scanner and remove clang16/gcc12 #320

merged 2 commits into from
Oct 9, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Oct 9, 2023 •
edited
Loading

needs to be added to sonarcloud before this build will be successfull ✔️

@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 11:18 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b1cb7c0) 56.23% compared to head (a0c6a42) 55.91%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   56.23%   55.91%   -0.32%     
==========================================
  Files          65       65              
  Lines        7083     7198     +115     
  Branches     2622     2619       -3     
==========================================
+ Hits         3983     4025      +42     
- Misses       1432     1506      +74     
+ Partials     1668     1667       -1

see 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 13:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 13:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 13:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 13:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 13:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm changed the title CI: add sonarcube scanner CI: add sonarcube scanner and remove clang16/gcc12 Oct 9, 2023
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:01 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:01 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:01 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:01 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:01 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 14:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:35 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:35 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:35 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:35 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:54 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:54 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:54 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 17:54 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 18:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 18:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 18:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 18:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 18:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 9, 2023 19:33 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

RalphSteinhagen
RalphSteinhagen approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@wirew0rm wirew0rm merged commit 3ab5a8f into main Oct 9, 2023
11 of 12 checks passed
@wirew0rm wirew0rm deleted the sonarcube branch October 9, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wirew0rm @RalphSteinhagen