RestBackend: Use real zmq subscription #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code was only looking for subscriptions that matched exactly the topic of the message. Instead look through all subscriptions and find the ones that match the topic.
The previous implementation used the Request Socket to send a subscription mdp command instead of using the broker's pub/sub endpoint. Also the naming and usage of the different Sockets was inconsistent. This changes the socket types and uses the SUB socket for subscriptions while using the dealer socket for get requests.
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 55.10% 55.08% -0.03%
==========================================
Files 68 68
Lines 7108 7111 +3
Branches 2640 2641 +1
==========================================
Hits 3917 3917
- Misses 1507 1509 +2
- Partials 1684 1685 +1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses the Request Socket to send a subscription mdp command instead of using the broker's pub/sub endpoint. Also the naming and usage of the different Sockets is inconsistent.
This changes the socket types and uses the SUB socket for subscriptions while using the dealer socket for get requests.
This might be incomplete and not handle every case and is not meant to be merged without further testing and discussion.