RestClientEmscripten: Fix UB in GET/SET

Do not take address of temporary.
fair-acc · Feb 5, 2024 · 9e244e5 · 9e244e5
1 parent 57f31a1
commit 9e244e5
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/client/include/RestClientEmscripten.hpp b/src/client/include/RestClientEmscripten.hpp
@@ -223,7 +223,6 @@ class RestClient : public ClientBase {
 
 private:
     void executeCommand(Command &&cmd) const {
-        auto                                                 uri             = opencmw::URI<>::factory(cmd.topic).build();
         auto                                                 preferredHeader = detail::getPreferredContentTypeHeader(cmd.topic, _mimeType);
         std::array<const char *, preferredHeader.size() + 1> preferredHeaderEmscripten;
         std::transform(preferredHeader.cbegin(), preferredHeader.cend(), preferredHeaderEmscripten.begin(),
@@ -269,8 +268,8 @@ class RestClient : public ClientBase {
 
         // TODO: Pass the payload as POST body: emscripten_fetch(&attr, uri.relativeRef()->data());
 
-        auto d = URI<>::factory(uri).addQueryParameter("_bodyOverride", body).build().str().data();
-        emscripten_fetch(&attr, d);
+        const auto uri = URI<>::factory(cmd.topic).addQueryParameter("_bodyOverride", body).build();
+        emscripten_fetch(&attr, uri.str().data());
     }
 
     void startSubscription(Command &&cmd) {