Put loom behind cfg(oneshot_loom) again #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #43. Loom is still optional, taking it out of the dependency graph and not polluting
Cargo.lock
for downstream users. But also "hide" the feature a bit more. It's still exposed incargo metadata
sadly. And building withcargo build --all-features
will enable theloom
feature. However just enabling the feature does nothing.This puts the dependency also behind
[target.'cfg(oneshot_loom)'.dependencies]
and all the code that is conditional on relying onloom
vsstd
now usecfg(oneshot_loom)
instead ofcfg(feature = "loom")
. This (again) makes it way harder for downstream users to accidentally compileoneshot
with loom integration turned on.So we are back to how things were before #43 but with the following differences:
optional
, loom is taken out of the default dependency treeloom
tooneshot_loom
to not collide with other loom-enabled crates, sinceRUSTFLAGS
are global.Ping @Wuelle :)