Added is_closed method #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thank you for the PR. I think this sounds like a nice method to have. Can you please rebase this on latest |
faern
requested changes
May 8, 2024
fulmicoton
force-pushed
the
main
branch
2 times, most recently
from
c3bc5db
to
c10a3ba
Compare
faern
reviewed
May 9, 2024
|
Thanks for the contribution! This seems like a useful method in some cases :) |
|
Is there a release planned @faern ? |
|
Yes! I just published 0.1.7: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
is_closedmethod to the oneshot Sender.The naming was copied from tokio's oneshot.
This PR was motivated by the following need.
A thread pool executor queues
FnOnce()->Ton a thread pool.The method used to schedule the execution of such a function returns a Receiver.
When the execution of a function arrives,
is_closedmakes it possible on the executor side to detect that no one is actually waiting on the result anymore, and the executor can skip the execution of the function entirely.