Feat/sort dependencies nullable and reasoning backfilling #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies and added support for zod schemas of nullable types. Also, added the corresponding spec for them.
jacobbamio
deleted the
feat/sort-dependencies-nullable-and-reasoning-backfilling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚪 Why?
Zod schemas of type nullable were returned after creating a workflow as Any or Undefined for Sorbet, which wasn't the intended behavior, we expected nilable.
Also, the order was not being considered, so dependencies and dependent structs were not working properly.
Last, we missed to add the backfilling for the reasoning_details that was covered by Mastra chat, with this we aim to solve this too.
🔑 What?
Refactored mastra client to handle reasoning_details, and the schema_struct_string to handle the sorting of dependencies, and having nullables translated the right way.
Updated version to the 0.4.2.