Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catpion extension #2492

Merged
merged 28 commits into from
Oct 18, 2024
Merged

Add catpion extension #2492

merged 28 commits into from
Oct 18, 2024

Conversation

facelessuser
Copy link
Owner

No description provided.

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: source Related to source code. C: tests Related to testing. C: details Related to the details extension. labels Oct 8, 2024
@gir-bot gir-bot added the C: infrastructure Related to project infrastructure. label Oct 17, 2024
@facelessuser facelessuser marked this pull request as ready for review October 17, 2024 01:50
@facelessuser facelessuser force-pushed the feature/caption branch 2 times, most recently from a625c6e to 39f6239 Compare October 17, 2024 16:06
facelessuser and others added 21 commits October 17, 2024 10:40
@facelessuser
Add catpion extension
37f6f20
@facelessuser
Spelling
9c8134b
@facelessuser
Prefix and auto ID fixes
5176775
@joapuiib @facelessuser
block caption extension: some tests (#2494)
0b3f8a7 
* block caption extension: basic and autoid tests

* block caption extension: prefix tests

* block caption extension: better naming

* block caption extension: prefix level tests
@facelessuser
Fix some tests and fix numbering indexing
c15412a
@facelessuser
Add prepend tests
429fca4
@facelessuser
Add manual ID case
afc9d92
@facelessuser
Test some prefix injection corner cases
ab085a5
@facelessuser
Tests related to captions and sibling figures
45cc9f1
@facelessuser
Add more tests and remove unused code
e1f1c3b
@facelessuser
Simplify conditional
82232db
@facelessuser
Refactor plugin
b424a35
@facelessuser
Ensure setting behavior is consistent with other similar extensions
9e77bfb
@facelessuser
Add final test to cover bad headers
6e3e361
@facelessuser
Fix documented default of auto_level
d4e78ed
@facelessuser
Make auto default
82b5c9e
@facelessuser
Allow manual numbers in auto mode and allow relative, virtual nesting
7aadbed
@facelessuser
Ensure auto_level is always positive
2548c68
@facelessuser
Code cleanup and add comments
82a9928
@facelessuser
Provide a sane result for manual and level depth setting
fbf21c5 
Specifying level depth while using manual mode does not have the context
to provide a relative number and is not recommended. But if it is used,
just return a value of all ones at the specified depth, e.g. 1, 1.1,
1.1.1, etc.
@facelessuser
Specifying depth increases depth relative to current depth
1dcd263 
Also this ensures children are relative to that element.
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Oct 18, 2024
@facelessuser facelessuser merged commit 2c7f8c0 into main Oct 18, 2024
18 checks passed
@facelessuser facelessuser deleted the feature/caption branch October 18, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: details Related to the details extension. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facelessuser @gir-bot @joapuiib