Improve the ray trace algorithm to yield better results in all spaces #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gir-bot
added
S: needs-review
The ray trace approach was designed focusing mainly on Oklab/OkLCh. Further evaluation shows that some spaces twist a little different through the RGB spaces and can yield results not as good, CIELCh being an example. Adjust the algorithm so that if a point is found along the reduction path below the gamut surface, that point becomes the new anchor. This generally tightness the range in a few passes and prevent some spaces from having larger than expected hue deviations.
facelessuser
force-pushed
the
enhance/raytrace-improve
branch
from
665dfff
to
4e3dc5a
Compare
|
@gir-bot lgtm |
gir-bot
added
S: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ray trace approach was designed focusing mainly on Oklab/OkLCh. Further evaluation shows that some spaces twist a little different through the RGB spaces and can yield results not as good, CIELCh being an example.
Adjust the algorithm so that if a point is found along the reduction path below the gamut surface, that point becomes the new anchor.
This generally tightness the range in a few passes and prevent some spaces from having larger than expected hue or lightness deviations.