Fix bindings stubs generation #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Regenerated bindings ``` buck run arvr/mode/platform010/opt //arvr/python/pyvrs2:vrsbindings_stubgen ``` This required a decent amount of work, because pybindings actually expect things to be declared in order of usage. In other words, you shouldn't declare a pybind for `void do_something(MyType foo);` before the pybinding `MyType` itself. This makes sense, but in practice, the VRS pybindings were breaking these rules in a myriad of ways, so I had to move a lot of things around, and it was quite annoying to do so... There is a way to prevent regression for this, I will reach out to VRS team about this... Differential Revision: D69120247
|
This pull request was exported from Phabricator. Differential Revision: D69120247 |
|
This pull request has been merged in 4e5072c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Regenerated bindings
This required a decent amount of work, because pybindings actually expect things to be declared in order of usage. In other words, you shouldn't declare a pybind for
void do_something(MyType foo);before the pybindingMyTypeitself.This makes sense, but in practice, the VRS pybindings were breaking these rules in a myriad of ways, so I had to move a lot of things around, and it was quite annoying to do so...
There is a way to prevent regression for this, I will reach out to VRS team about this...
Differential Revision: D69120247