Skip to content

to_gltf renamed to save_gltf_to_dict. #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

to_gltf renamed to save_gltf_to_dict. #570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
141815e
Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)
cdtwigg Sep 22, 2025
95af0a2
to_gltf renamed to save_gltf_to_dict. (#570)
cdtwigg Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pymomentum/geometry/geometry_pybind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ PYBIND11_MODULE(geometry, m) {
//
// [static methods for io]
// - load_gltf_from_bytes(gltf_btyes)
// - to_gltf(character, fps, motion, offsets)
// - save_gltf_to_dict(character, fps, motion, offsets)
// - load_fbx(fbxFilename, modelFilename, locatorsFilename)
// - load_fbx_from_bytes(fbx_bytes, permissive)
// - load_fbx_with_motion(fbxFilename, permissive)
Expand All @@ -246,7 +246,7 @@ PYBIND11_MODULE(geometry, m) {
// - load_urdf(urdf_filename)
// - load_urdf_from_bytes(urdf_bytes)
// - save_gltf(path, character, fps, motion, offsets, markers)
// - save_gltf_from_skel_states(path, character, fps, skel_states,
// - save_gltf_with_skel_states(path, character, fps, skel_states,
// joint_params, markers)
// - save_fbx(path, character, fps, motion, offsets)
// - save_fbx_with_joint_params(path, character, fps, joint_params)
Expand Down Expand Up @@ -689,7 +689,7 @@ Note: In practice, most limits are enforced on the model parameters, but momentu
py::arg("gltf_bytes"))
// toGLTF(character, fps, motion)
.def_static(
"to_gltf",
"save_gltf_to_dict",
&toGLTF,
py::call_guard<py::gil_scoped_release>(),
R"(Serialize a character as a GLTF using dictionary form.
Expand Down Expand Up @@ -890,7 +890,7 @@ support the proprietary momentum motion format for storing model parameters in G
py::arg("markers") =
std::optional<const std::vector<std::vector<momentum::Marker>>>{})
.def_static(
"save_gltf_from_skel_states",
"save_gltf_with_skel_states",
&saveGLTFCharacterToFileFromSkelStates,
py::call_guard<py::gil_scoped_release>(),
R"(Save a character to a gltf file.
Expand Down
Loading