Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpsampler #2995

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michaelriedl
Copy link

Motivation

I wanted to bring the Optuna plugin up to date with the newest version. I made the necessary changes to make the plugin compatible. I also added in the GPSampler even though it is still experimental since some people may want to use it.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I modified the existing tests in the plugin folder. I have tested that they pass on my WSL setup.

Related Issues and PRs

None.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2024
@michaelriedl
Copy link
Author

I did not realize that I basically duplicated #2360. Can we merge one of these in?

@michaelriedl
Copy link
Author

It also appears that the workflows for CI do not trigger with a PR from a forked branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants