Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Rotate Labels: Fix bugs and feedback #214

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Rotate Labels: Fix bugs and feedback #214

merged 2 commits into from
Sep 30, 2021

Conversation

danthe3rd
Copy link
Contributor

No description provided.

@danthe3rd danthe3rd changed the title Fix bugs and feedback Rotate Labels: Fix bugs and feedback Sep 30, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2021
@danthe3rd danthe3rd merged commit cf5d3ae into main Sep 30, 2021
@danthe3rd danthe3rd deleted the rotate_fix branch September 30, 2021 12:43
@mathematicalmichael
Copy link

hi there. I've tried to track down which recent changes to hiplot resulted in my plots getting significantly harder to read, and narrowed it down to 0.1.28 -> 0.1.29 and believe this is the PR responsible.

This perfectly readable and stacked display:
Screen Shot 2021-10-24 at 12 56 37 PM
turned into
Screen Shot 2021-10-24 at 12 57 35 PM
which cuts off the final column name if I make the window any more narrow and causes a weird spacing issue on the right-side.

I very much support improving the visual interface of hiplot but I believe this hurt the overall experience. Would you be open to discussing some of the changes made here and perhaps a partial revert? Or am I best served maintaining a separate fork of the project? (I am not a front-end developer but am trying very hard to use hiplot in a tool I am building).

@mathematicalmichael
Copy link

The above screenshots were in Opera (I've noticed Safari has had existing trouble with dragging columns).
I also noticed that on Safari, this same change resulted in "ghosting" of the headers upon scrolling (and did not fix the aforementioned problem):
Screen Shot 2021-10-24 at 1 01 39 PM

@mathematicalmichael
Copy link

Screen Shot 2021-10-24 at 1 03 20 PM

(that's the "rearranging" problem in safari I mentioned, the annotation divorces from the column)

@danthe3rd
Copy link
Contributor Author

Hey @mathematicalmichael - thank you for taking time to report this. Let's move the discussion to an issue rather than a closed PR (#218)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants