-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--Set default fallback material handling #2265
Draft
jturner65
wants to merge
3
commits into
main
Choose a base branch
from
DfltFallbackMaterials
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ac3229
to
41b6fcc
Compare
579d931
to
4f114ba
Compare
4f114ba
to
4d3b00c
Compare
5a87217
to
419dd20
Compare
dfe520d
to
92ac4da
Compare
38996c7
to
15dbe47
Compare
df87790
to
a25b8c6
Compare
1a31f92
to
169946d
Compare
8f74add
to
d06df58
Compare
b2d5dc8
to
37554a4
Compare
3e348b4
to
f545426
Compare
f545426
to
a432c4f
Compare
a432c4f
to
3d1f8ed
Compare
1e3d4dc
to
03866b8
Compare
0929bdf
to
bdc9439
Compare
e5456b9
to
725338e
Compare
c549c76
to
6fe5da6
Compare
1dd923f
to
8985a20
Compare
--make material color magenta --add flag that this material is a fallback for an object lacking any other materials --remove default phong material function; specifying phong shader to use should be sufficient for depth sensor.
--this could indicate that the source asset lacks a material, or else that no materials were loaded by design (i.e. for depth sensor).
8985a20
to
ba3e7d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR provides some extensions to the fall back material handling.
Still a WIP
How Has This Been Tested
Types of changes
Checklist