Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE Week]Modify ESP_CHECK to exit not abort. #2143

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

--[BE Week]Modify ESP_CHECK to exit not abort. #2143

wants to merge 4 commits into from
+1,019 −568

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Currently our ESP_CHECK macro was exiting the program via std::abort(), providing a core dump. However, it is most often used to verify data or check the results of file IO, for which a core dump is undesirable. This PR changes ESP_CHECK to std::exit(1) instead, avoiding the core dump.

An alternative mechanism that provides the assertion-like behavior with the std::abort/core dump functionality while also communicating with python properly is being investigated for a future PR.

How Has This Been Tested

All current c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 30, 2023
@jturner65 jturner65 requested a review from aclegg3 July 3, 2023 19:15
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 07a405e to 1b998f7 Compare July 6, 2023 10:06
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from d4a44be to 5892a01 Compare September 27, 2023 19:13
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from e8deb90 to a5c2fb0 Compare November 29, 2023 14:40
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from 83e06d3 to 3c6be66 Compare December 12, 2023 17:24
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 3a2fe6c to 5016d85 Compare January 4, 2024 13:52
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 94ac25a to 9f83102 Compare January 9, 2024 21:16
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 162c2aa to 09435f6 Compare January 29, 2024 19:22
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 1d05c99 to da65296 Compare February 5, 2024 14:07
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 56c082b to daa7e2b Compare April 22, 2024 13:33
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from bc4bc8f to 1dde8a6 Compare May 2, 2024 13:20
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 3 times, most recently from 8bcb838 to a0d52e5 Compare May 9, 2024 13:45
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from a6d16aa to 4db7335 Compare May 13, 2024 18:50
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 38f3b51 to 1a3bce4 Compare June 18, 2024 13:51
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 3073266 to 6e98d6f Compare July 25, 2024 15:27
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from edfd813 to 257a5bc Compare August 13, 2024 14:00
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from c580f32 to 0e21e20 Compare August 25, 2024 15:47
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 32f95fd to 383eec7 Compare September 5, 2024 12:58
@jturner65
--[Bugfix] - Scene Reset Redundancy (#2470)
0620632 
* --modify reset() to not perform redundant object re-placement
After successful scene creation, reset is called, but the objects have all already been placed in their initial positions.

* --fix bindings
Don't expose the boolean in reset to python, should only be consumed from Simulator::reconfigure
@jturner65
--[BE] - Add ability to filter Configuration subconfigs (#2471)
9f2a3d7 
* --add subconfig filtering process.
This function will remove any values and subconfigs from a Configuration that match those found within a passed Configuration.
* --minor naming clarification
* --expand Configuration tests to test filtering; rename test
Test only tests Configurations, so name appropriately
@jturner65
--[Bugfix] - Address ObjectInstanceAttributes save issues (#2472)
3bb430f 
* --access init instance attributes for an rigid/AO via const ref or copy
* --access sim directly to query for defaultCOMCorrection state
So that objects added to an existing scene will use the correct defaultCOMCorrection state.
* --verify requested type is appropriate
* --add queries for current state of Configuration fields
Query whether a field is a default value, a hidden value or backed by an enum (i.e. 'translated')
* --properly set enum-backed/'translated' string fields in instance attrs
* --add is_visible boolean for AOs
For instance consistency - not yet supported.
* --only set instance vals if not default config vals; clean up JSON write
Configuration now supports not writing initialization/default fields to JSON.
* --Add access to user_defined view and setter
* --better names for object init attrs and object instance  init attrs
* --use base obj's current state to build ObjectInstanceAttr and obj copy
* --only change fields if they are different than defaults.
@jturner65
--modify ESP_CHECK to exit not abort.
ea1e587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mosra mosra Awaiting requested review from mosra

@eundersander eundersander Awaiting requested review from eundersander

@0mdc 0mdc Awaiting requested review from 0mdc

@aclegg3 aclegg3 Awaiting requested review from aclegg3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @Skylion007 @facebook-github-bot